ashb commented on code in PR #60152:
URL: https://github.com/apache/airflow/pull/60152#discussion_r2687516055


##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -1059,46 +1059,62 @@ async def cleanup_finished_triggers(self) -> list[int]:
             await asyncio.sleep(0)
         return finished_ids
 
-    async def sync_state_to_supervisor(self, finished_ids: list[int]):
+    def validate_state_changes(self, finished_ids: list[int]) -> 
messages.TriggerStateChanges:

Review Comment:
   This method name is a bit off -- given it returns the state changes, I'd 
suggest calling it something like process_ or serialize_ etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to