phanipaladugula commented on code in PR #60485:
URL: https://github.com/apache/airflow/pull/60485#discussion_r2688164578
##########
task-sdk/src/airflow/sdk/__init__.py:
##########
@@ -158,6 +160,7 @@
"literal": ".definitions.template",
"setup": ".definitions.decorators",
"task": ".definitions.decorators",
+ "TaskInstance": ".api.datamodels._generated",
Review Comment:
Hi Kaxil! Thanks for the catch. I looked at the definition in types.py, but
I initially went with the one in _generated.py because it seems to be the full
model from the Execution API spec, including fields like dag_version_id and
context_carrier.
Since the original issue (#60478) mentioned that the available parameters
weren't documented, I thought the generated model provided the most complete
attribute list for the Sphinx docs to scrape.
That said, if we want types.py to be the official public entry point, I’m
happy to switch the export to point there! Should I update the PR to use the
types.py version instead?"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
