KyeongJooni commented on code in PR #59738:
URL: https://github.com/apache/airflow/pull/59738#discussion_r2690330650
##########
airflow-core/src/airflow/ui/tests/e2e/pages/BackfillPage.ts:
##########
@@ -340,10 +386,20 @@ export class BackfillPage extends BasePage {
await menuItem.click();
}
- public async waitForNoActiveBackfill(): Promise<void> {
- const backfillInProgress = this.page.locator('text="Backfill in
progress:"');
+ public async waitForNoActiveBackfill(timeout: number = 300_000):
Promise<void> {
+ const { page } = this;
+ const backfillInProgress = page.locator('text="Backfill in progress:"');
- await expect(backfillInProgress).not.toBeVisible({ timeout: 300_000 });
+ await expect(async () => {
+ await page.reload();
+ await page.waitForLoadState("networkidle", { timeout: 30_000 });
Review Comment:
Thanks for pointing this out. I've removed all networkidle usages and
replaced them with explicit UI element waits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
