kaxil commented on code in PR #60522:
URL: https://github.com/apache/airflow/pull/60522#discussion_r2690771614
##########
task-sdk/tests/task_sdk/execution_time/test_task_runner.py:
##########
@@ -647,6 +576,12 @@ def sleep_and_catch_other_exceptions():
_execute_task(context=ti.get_template_context(), ti=ti,
log=mock.MagicMock())
+
+def test_task_deferral_timeout_fix():
+ """Test for #60517 - TaskDeferralTimeout handling fix"""
Review Comment:
No need to include issues number here
##########
task-sdk/tests/task_sdk/execution_time/test_task_runner.py:
##########
@@ -647,6 +576,12 @@ def sleep_and_catch_other_exceptions():
_execute_task(context=ti.get_template_context(), ti=ti,
log=mock.MagicMock())
+
+def test_task_deferral_timeout_fix():
+ """Test for #60517 - TaskDeferralTimeout handling fix"""
+ from airflow.sdk.exceptions import TaskDeferralTimeout
Review Comment:
Why import inside the test vs at the top?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
