zach-overflow commented on PR #60176:
URL: https://github.com/apache/airflow/pull/60176#issuecomment-3749568378

   > Well, good news is that it works! Quick question, this broke PR #58248 
which was importing and using SerializedDag's hash method. What is the expected 
fix here? Copy/Pasting the method into the migration feels like the wrong 
answer, but I can no longer import it either.
   
   So it looks like there's only [one offending 
line](https://github.com/apache/airflow/pull/58248/files#diff-e820ea065c602b61b0071899c9735bbf2c138123a8bf39ebc37703e3106f09dfR479)
 in that PR. I am not sure if there is a cleaner solution than copy-pasting the 
`SerializedDagModel.hash` method into the migration script. Also, I believe the 
direct hash method reference could also potentially cause divergent behavior if 
the method were ever to change in subsequent commits. Copy-pasting feels a bit 
clunky, but it will ensure consistency.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to