pierrejeambrun commented on code in PR #59564: URL: https://github.com/apache/airflow/pull/59564#discussion_r2691219917
########## airflow-core/src/airflow/api_fastapi/auth/managers/base_auth_manager.py: ########## @@ -75,7 +75,7 @@ # List of methods (or actions) a user can do against a resource ResourceMethod = Literal["GET", "POST", "PUT", "DELETE"] # Extends ``ResourceMethod`` to include "MENU". The method "MENU" is only supported with specific resources (menu items) -ExtendedResourceMethod = Literal["GET", "POST", "PUT", "DELETE", "MENU"] +ExtendedResourceMethod = Literal["GET", "POST", "PUT", "DELETE", "MENU", "PATCH"] Review Comment: What would it take to have that "PATCH" available for all auth manager? So we can have code in the API 'matching perms'. "PATCH" permission for PATCH endpoint, instead of "PUT" permission for "PATCH" currently :( That would be a good quality of life (even if the "PATCH under the hood maps to a "PATCH") ########## airflow-core/src/airflow/api_fastapi/auth/managers/base_auth_manager.py: ########## @@ -75,7 +75,7 @@ # List of methods (or actions) a user can do against a resource ResourceMethod = Literal["GET", "POST", "PUT", "DELETE"] # Extends ``ResourceMethod`` to include "MENU". The method "MENU" is only supported with specific resources (menu items) -ExtendedResourceMethod = Literal["GET", "POST", "PUT", "DELETE", "MENU"] +ExtendedResourceMethod = Literal["GET", "POST", "PUT", "DELETE", "MENU", "PATCH"] Review Comment: What would it take to have that "PATCH" available for all auth manager? So we can have code in the API 'matching perms'. "PATCH" permission for PATCH endpoint, instead of "PUT" permission for "PATCH" currently :( That would be a good quality of life (even if the "PATCH under the hood maps to a "PUT") -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
