ebongzzang opened a new pull request, #60562:
URL: https://github.com/apache/airflow/pull/60562
## What change does this PR introduce?
- Fixes the method `airflow.sdk.definitions.asset.Asset.__hash__()` in
task-sdk which was attempting to hash a dictionary directly, causing a
`TypeError`.
- The current implementation attempts to hash a dictionary directly, which
is not allowed in Python since dictionaries are mutable and unhashable. This
prevents Asset objects from being used in sets or as dictionary keys, which is
inconsistent with the `__eq__` implementation.
## Changes
- Modified `__hash__` to serialize the attrs dictionary to JSON string using
`json.dumps(sort_keys=True)` before hashing.
- Applied the same pattern used in the codebase for hashing dictionaries:
- Similar to airflow/triggers/base.py:147 which uses json.dumps() to
serialize kwargs before hashing.
- Similar to airflow/providers/standard/operators/python.py:834-836
which uses json.dumps(hash_dict, sort_keys=True) to create a hashable string.
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
