bbovenzi commented on code in PR #60581:
URL: https://github.com/apache/airflow/pull/60581#discussion_r2694857027
##########
airflow-core/src/airflow/ui/src/components/DagRunInfo.tsx:
##########
@@ -40,39 +41,43 @@ const DagRunInfo = ({ endDate, logicalDate, runAfter,
startDate, state }: Props)
<Tooltip
content={
<VStack align="left" gap={0}>
- {state === undefined ? undefined : (
+ {state === undefined ? (
<Text>
- {translate("state")}: {translate(`common:states.${state}`)}
+ {translate("dagDetails.nextRun")}: {getRelativeTime(runAfter)}
</Text>
+ ) : (
+ <>
+ <Text>
+ {translate("state")}: {translate(`common:states.${state}`)}
+ </Text>
+ {Boolean(logicalDate) && (
+ <Text>
+ {translate("logicalDate")}: <Time datetime={logicalDate} />
+ </Text>
+ )}
+ {Boolean(startDate) && (
+ <Text>
+ {translate("startDate")}: <Time datetime={startDate} />
+ </Text>
+ )}
+ {Boolean(endDate) && (
+ <Text>
+ {translate("endDate")}: <Time datetime={endDate} />
+ </Text>
+ )}
+ {Boolean(startDate) && (
+ <Text>
+ {translate("duration")}: {getDuration(startDate, endDate)}
+ </Text>
+ )}
+ </>
)}
- {Boolean(logicalDate) ? (
- <Text>
- {translate("logicalDate")}: <Time datetime={logicalDate} />
- </Text>
- ) : undefined}
- {Boolean(startDate) ? (
- <Text>
- {translate("startDate")}: <Time datetime={startDate} />
- </Text>
- ) : undefined}
- {Boolean(endDate) ? (
- <Text>
- {translate("endDate")}: <Time datetime={endDate} />
- </Text>
- ) : undefined}
- {Boolean(startDate) ? (
- <Text>
- {translate("duration")}: {getDuration(startDate, endDate)}
- </Text>
- ) : undefined}
</VStack>
}
>
<Box>
- <Time datetime={runAfter} mr={2} showTooltip={false} />
- {state === undefined ? undefined : (
- <StateBadge aria-label={state} data-testid="state-badge"
state={state} />
- )}
+ <Time datetime={runAfter} mr={2} showTooltip={false} title="" />
Review Comment:
What's with the blank title here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
