dominikhei opened a new pull request, #60597:
URL: https://github.com/apache/airflow/pull/60597

   
   closes: #55708
   
   This PR introduces 2 new parameters to the S3CopyObjectOperator. With these 
one can specify a non-default KMS key when copying objects between buckets.
   
   
   - `kms_key_id`: The ARN, ID or alias of a KMS key
   - `kms_encryption_type`: Whether it is standard KMS or double-shielded KMS
   
   The parameters are passed to the Hooks `copy_object()` method using kwargs, 
which passes them to the boto3 method.
   I did this to not introduce new parameters to the method and keep changes 
minimal, however I also see a point that this is not as clean as passing them 
to the method via parameters and if deemed preferential will change that.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [] Yes  
   
   <!--
   Generated-by: [gpt o5] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to