potiuk commented on PR #60321: URL: https://github.com/apache/airflow/pull/60321#issuecomment-3756291841
@GaneshPatil7517 - are you actually looking at the rebase and changes? You wrote that you accidentally used another PR and rebased but It does not seem you did. I willl close the PR now, and I would encourage you to make the change again starting from top of current main. I generally agree that http check is usually better for long running components, because "exec" paired with running "airflow" command starts a new process - and that has a number of possible side-effects - from peaks in memory usage when we have to start new interpreter, to some potential memory leaks in the exec mechanism itself (there we issues connected with it in the past. So I think it's a good idea to add it, But it's wasting time of maintainers when they have to point out multiple times that there are unrelated changes - and even after acknowledging that, they unrelated changes remain. Closing now @GaneshPatil7517 - please start a new. And if you are using AI to generate such PRs, there is a new requirement and checkbox to set and explanation of what AI is used and link to our guidelines explaining our expectations for AI generated PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
