Miretpl commented on PR #60420: URL: https://github.com/apache/airflow/pull/60420#issuecomment-3757141555
Hi @jscheffl, regarding this PR - maybe. I have core working locally (there are some edge cases that I'm working on now - I'm unsure how long they will take to resolve tho). There is a chance that we will need to revert #52357 change. I'm not sure now how it should work with `workers.celery.sets`, but it will need to be rebuilt in some way too. I guess we can always revert it and bring it back in some other form with the release after 1.19. Also, the current version on main doesn't work, and I mean not only `workers` separation, but `workers.celery.sets` too (which can be seen in the already added tests on this PR). All of the values (despite `replicas`) which have been moved to `workers.celery` cannot be overwritten by sets (if they have default value). IMHO, if I do not finish this by Monday, I'm not sure if it would be a good decision to release 1.19.0 in its current state. Regarding further renaming - I planned to get back to them after this PR, but if 1.19 is close to the release, I will probably add tests for the added `PodDistributionBudgets`, cause most of the additions after 1.18.0 release do not really have any tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
