henry3260 commented on code in PR #60427:
URL: https://github.com/apache/airflow/pull/60427#discussion_r2697270409
##########
chart/templates/NOTES.txt:
##########
@@ -204,6 +204,14 @@ DEPRECATION WARNING:
{{- end }}
+{{- if not (empty .Values.workers.kerberosInitContainer) }}
Review Comment:
> Is there any scenario that this condition will not be met? Cause I believe
there isn't, and I think we should not print a deprecation message if the user
will not use the deprecated section (e.g. that situation is when the section
has all default values set).
Indeed, maybe we should print a deprecation message` {{- if
.Values.workers.kerberosInitContainer.enabled }}`? WDYT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
