shahar1 commented on code in PR #60684: URL: https://github.com/apache/airflow/pull/60684#discussion_r2700732531
########## COMMITTERS.rst: ########## @@ -216,7 +216,7 @@ To be able to merge PRs, committers have to integrate their GitHub ID with Apach 2. Merge your Apache and GitHub accounts using `GitBox (Apache Account Linking utility) <https://gitbox.apache.org/setup/>`__. This also asks you to link your GitHub ID to your Apache account. You should see 5 green checks in GitBox. 3. Wait at least 30 minutes for an email inviting you to Apache GitHub Organization and accept invitation. -4. After accepting the GitHub Invitation verify that you are a member of the `Airflow committers team on GitHub <https://github.com/orgs/apache/teams/airflow-committers>`__. Review Comment: This shouldn't be changed - it's an internal page shown only to committers, so new committers could officialy validate their registration to the GitHub's org. ########## contributing-docs/01_roles_in_airflow_project.rst: ########## @@ -54,7 +54,6 @@ The official list of committers can be found `here <https://airflow.apache.org/d Additionally, committers are listed in a few other places (some of these may only be visible to existing committers): * https://whimsy.apache.org/roster/committee/airflow -* https://github.com/orgs/apache/teams/airflow-committers/members Review Comment: As the comment above states, both links are visible only to existing committers - so if you're non-committer and try to access them you may receive an error. However, as this specific page is intended to new contributors and could create confusion - I agree that these lines should be relocated to the `COMMITTERS.rst`, as part of section 4 in "New Committer Onboarding Steps" (and then the "some of these..." comment could be safely removed as well). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
