This is an automated email from the ASF dual-hosted git repository.
shahar pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new e77345b9f6d Remove erroneous _handle_job_error call during BigQuery
job reattach (#60679)
e77345b9f6d is described below
commit e77345b9f6d5f2674fbe737200a21876be61422f
Author: Deji Ibrahim <[email protected]>
AuthorDate: Sat Jan 17 09:36:34 2026 +0100
Remove erroneous _handle_job_error call during BigQuery job reattach
(#60679)
---
.../src/airflow/providers/google/cloud/operators/bigquery.py | 1 -
.../tests/unit/google/cloud/operators/test_bigquery.py | 12 ++++--------
2 files changed, 4 insertions(+), 9 deletions(-)
diff --git
a/providers/google/src/airflow/providers/google/cloud/operators/bigquery.py
b/providers/google/src/airflow/providers/google/cloud/operators/bigquery.py
index 54994bc5d59..a1a0c310b7e 100644
--- a/providers/google/src/airflow/providers/google/cloud/operators/bigquery.py
+++ b/providers/google/src/airflow/providers/google/cloud/operators/bigquery.py
@@ -2428,7 +2428,6 @@ class BigQueryInsertJobOperator(GoogleCloudBaseOperator,
_BigQueryInsertJobOpera
# We are reattaching to a job
self.log.info("Reattaching to existing Job in state %s", job.state)
- self._handle_job_error(job)
job_types = {
LoadJob._JOB_TYPE: ["sourceTable", "destinationTable"],
diff --git
a/providers/google/tests/unit/google/cloud/operators/test_bigquery.py
b/providers/google/tests/unit/google/cloud/operators/test_bigquery.py
index bdecca4f46b..c1eed574ad0 100644
--- a/providers/google/tests/unit/google/cloud/operators/test_bigquery.py
+++ b/providers/google/tests/unit/google/cloud/operators/test_bigquery.py
@@ -1173,11 +1173,8 @@ class TestBigQueryInsertJobOperator:
with pytest.raises(AirflowException):
op.execute(context=MagicMock())
- @mock.patch(
-
"airflow.providers.google.cloud.operators.bigquery.BigQueryInsertJobOperator._handle_job_error"
- )
@mock.patch("airflow.providers.google.cloud.operators.bigquery.BigQueryHook")
- def test_execute_reattach(self, mock_hook, _handle_job_error):
+ def test_execute_reattach(self, mock_hook):
job_id = "123456"
hash_ = "hash"
real_job_id = f"{job_id}_{hash_}"
@@ -1196,6 +1193,8 @@ class TestBigQueryInsertJobOperator:
state="RUNNING",
done=lambda: False,
)
+ # Simulate job.result() completing - job transitions to DONE state
+ job.result.side_effect = lambda **_: setattr(job, "state", "DONE")
mock_hook.return_value.get_job.return_value = job
mock_hook.return_value.generate_job_id.return_value = real_job_id
@@ -1550,11 +1549,8 @@ class TestBigQueryInsertJobOperator:
assert operator.job_id == job_id
@pytest.mark.db_test
- @mock.patch(
-
"airflow.providers.google.cloud.operators.bigquery.BigQueryInsertJobOperator._handle_job_error"
- )
@mock.patch("airflow.providers.google.cloud.operators.bigquery.BigQueryHook")
- def test_bigquery_insert_job_operator_with_job_id_generate(self,
mock_hook, _handle_job_error):
+ def test_bigquery_insert_job_operator_with_job_id_generate(self,
mock_hook):
job_id = "123456"
hash_ = "hash"
real_job_id = f"{job_id}_{hash_}"