Jarek Potiuk created AIRFLOW-6178:
-------------------------------------
Summary: When PR deletes dependencies, they are not removed for CI
build
Key: AIRFLOW-6178
URL: https://issues.apache.org/jira/browse/AIRFLOW-6178
Project: Apache Airflow
Issue Type: Bug
Components: ci
Affects Versions: 1.10.6, 2.0.0
Reporter: Jarek Potiuk
When PIP dependencies are removed in PR, they are not removed even if you
increase {{PIP_DEPENDENCIES_EPOCH_NUMBER}}
It was supposed to be handled by this:
{{# Increase the value here to force reinstalling Apache Airflow pip
dependencies
ARG PIP_DEPENDENCIES_EPOCH_NUMBER="2"
ENV PIP_DEPENDENCIES_EPOCH_NUMBER=${PIP_DEPENDENCIES_EPOCH_NUMBER}}}
This should trigger reinstallation of all dependencies from the scratch in case
we know we deleted some dependencies (nose in this case). This is done via:
{{pip install \
"https://github.com/apache/airflow/archive/${AIRFLOW_BRANCH}.tar.gz#egg=apache-airflow[${AIRFLOW_EXTRAS}]";
\
&& pip uninstall --yes apache-airflow;}}
However in case of PR from another repo, AIRFLOW_BRANCH is still set to
"master" (this is the TARGET branch) and it uses "airflow" Github
organisation/user.
This means that in the PR, dependencies will be installed first from the master
branch of Airflow. Which (at the time of PR) included nose.
What it SHOULD happen instead - in case of PR, it should be something like:
{{pip install \
"https://github.com/apache/${SOURCE_GITHUB_USER}/archive/${SOURCE_BRANCH}.tar.gz#egg=apache-airflow[${AIRFLOW_EXTRAS}]";
\
&& pip uninstall --yes apache-airflow;}}
This perfectly explains what happened.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
