Prab-27 commented on PR #60043:
URL: https://github.com/apache/airflow/pull/60043#issuecomment-3763926376
@potiuk , When I tried to commit -
```
from providers.google.tests.system.google import
DEFAULT_GCP_SYSTEM_TEST_PROJECT_ID
from providers.openlineage.tests.system.openlineage.operator import
OpenLineageTestOperator
```
Ruff failed checks -
```
- Run 'ruff' for extremely fast Python
linting.....................................Failed
- hook id: ruff
- exit code: 1
TID251 `providers` is banned: You should not import 'providers' as a
Python module. Imports in providers should be done starting from 'src' or
`tests' folders, for example 'from airflow.providers.airbyte' or 'from
unit.airbyte' or 'from system.airbyte'
-->
providers/google/tests/system/google/cloud/bigquery/example_bigquery_queries.py:49:1
|
47 | from airflow.utils.trigger_rule import TriggerRule # type:
ignore[no-redef,attr-defined]
48 |
49 | from providers.google.tests.system.google import
DEFAULT_GCP_SYSTEM_TEST_PROJECT_ID
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
50 | from providers.openlineage.tests.system.openlineage.operator import
OpenLineageTestOperator
|
TID251 `providers` is banned: You should not import 'providers' as a
Python module. Imports in providers should be done starting from 'src' or
`tests' folders, for example 'from airflow.providers.airbyte' or 'from
unit.airbyte' or 'from system.airbyte'
-->
providers/google/tests/system/google/cloud/bigquery/example_bigquery_queries.py:50:1
|
49 | from providers.google.tests.system.google import
DEFAULT_GCP_SYSTEM_TEST_PROJECT_ID
50 | from providers.openlineage.tests.system.openlineage.operator import
OpenLineageTestOperator
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
51 |
52 | ENV_ID = os.environ.get("SYSTEM_TESTS_ENV_ID", "default")
|
Found 2 errors.
```
I'm working on fixing this it but from
this(https://github.com/apache/airflow/pull/60676#issuecomment-3763705279)
should I revert this `ruff ` to `prek` hook script ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
