potiuk commented on PR #60663: URL: https://github.com/apache/airflow/pull/60663#issuecomment-3764070499
> Hello @kaxil , @kacpermuda found an issue with the backward compat baseoperator due to my [PR](https://github.com/apache/airflow/pull/60268) which add's support for async callable in PythonOperator. This PR is a fix for that issue. Good catch BTW by @kacpermuda. Question, don't we run backward compat tests of providers with Airflow 2.x? I would have expected this to have failed tests. Generally yes. We take all the tests we have for providers and run them against 2.11 -> https://github.com/apache/airflow/actions/runs/21096649515/job/60675322714 for example. But maybe there is no test to run this path or maybe it is disabled for Airflow 2 (some tests are disabled because they are not even supposed to work on Airflow 2) @kacpermuda -> @dabla. Maybe you can see if there was a test missing that would cover that path and add it ? Note that we are **not** running "airflow 2" core tests in those tests - only provider tests. So my best guess is that none of the "standard" provider tests or "lineage" provider tests actually run the code that triggerred the issue and we should add it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
