dabla commented on PR #60704: URL: https://github.com/apache/airflow/pull/60704#issuecomment-3764105147
> > This is weird, as I would expect the host url defined in your PowerBI connection to be automatically prepended to the relative url. The PowerBIHook extends the KiotaRequestAdapterHook, thus I would expect to behave in the same way. > > Also, why did you fully replace the code in the hook and test, this makes it very difficult to review? > > Could you post an example DAG how it's used and connection example? > > Regarding the URL handling: I had the same expectation initially, however in practice PowerBIHook.run() ends up passing relative paths (e.g. myorg/groups) directly to the async request adapter, which then fails with: > > `Request URL is missing an 'http://' or 'https://' protocol` > > This suggests the host configured in the hook is not being prepended for these calls. The issue is reproducible with a standard Power BI connection and occurs consistently when calling get_workspace_list() and other Power BI hook methods. The actual logic change in this PR is intentionally minimal: it only normalizes relative Power BI REST endpoints before delegating to super().run(). Absolute URLs are left untouched. The larger diff is due to formatter and import reordering enforced by CI after rebasing; no additional behavior beyond URL normalization was changed. The relative url is automatically concatenated with the host by the RequestAdapter's RequestInformation class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
