potiuk commented on PR #60716: URL: https://github.com/apache/airflow/pull/60716#issuecomment-3764165523
> Thank you for your commitment, i understand your proposal. But from my perspective it should be discussed inside the google team if we want someone to be a codeowner of Google provider, other than someone who is actually working actively for Google. For now i would kindly ask to revert this change before i can discuss this inside the team. Yes @eladkal is right - CODEOWNER is nothing more than being notified when there is a change and setting that person as reviewer - the name of this feature is **wrong** (naming is hard). Because this is not about ownership - ASF is the owner of such code at the moment it is merged - and no-one else is, neither maintainers nor google code. And any of the maintainers can add themselves to be notified when there are changes to the code - there is nothing wrong with it. We are also addressing it better in the future when it comes to notifying Google team and other stakeholders via https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-95+Provider+lifecycle+update+proposal - there will be dashboards implemented over time and notification mechanisms that will work beyond just maintainers. And we are introducing stewardship concept - but even that stewardship does not mean that any maintainer can anyhow approve and merge a code in any part of the code. Only maintainers (committers) can give binding +1 to any of the code to merge it - this is governed by the ASF voting on code modification https://www.apache.org/foundation/voting.html#votes-on-code-modification - where only commiters / maintainers have a binding +1 (and also -1 being veto) - others, who are not committers can have advisory votes and with our stewardship proposal we have soft internal agreement on steward being involved and generally necessary (except some common global refactors and such) to have a say. But still any of the maintainers can choose to be added to CODEOWNERS to be notified if they want to. AIP-95 does not change it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
