Miretpl commented on code in PR #60677:
URL: https://github.com/apache/airflow/pull/60677#discussion_r2701342019
##########
chart/templates/workers/worker-deployment.yaml:
##########
@@ -191,11 +193,13 @@ spec:
subPath: {{ .Values.logs.persistence.subPath }}
{{- end }}
{{- end }}
- {{- $kerberosInitContainerEnabled := or
(.Values.workers.celery.kerberosInitContainer).enabled
(.Values.workers.kerberosInitContainer).enabled }}
+ {{- $kerberosInitContainerEnabled := or
(.Values.workers.celery.kerberosInitContainer).enabled (and (not (has
(.Values.workers.celery.kerberosInitContainer).enabled (list true false)))
(.Values.workers.kerberosInitContainer).enabled) }}
Review Comment:
```suggestion
{{- $kerberosInitContainerEnabled := or
.Values.workers.celery.kerberosInitContainer.enabled (and (not (has
.Values.workers.celery.kerberosInitContainer.enabled (list true false)))
.Values.workers.kerberosInitContainer.enabled) }}
```
##########
chart/templates/workers/worker-deployment.yaml:
##########
@@ -191,11 +193,13 @@ spec:
subPath: {{ .Values.logs.persistence.subPath }}
{{- end }}
{{- end }}
- {{- $kerberosInitContainerEnabled := or
(.Values.workers.celery.kerberosInitContainer).enabled
(.Values.workers.kerberosInitContainer).enabled }}
+ {{- $kerberosInitContainerEnabled := or
(.Values.workers.celery.kerberosInitContainer).enabled (and (not (has
(.Values.workers.celery.kerberosInitContainer).enabled (list true false)))
(.Values.workers.kerberosInitContainer).enabled) }}
{{- $kerberosInitContainerResources :=
(.Values.workers.celery.kerberosInitContainer).resources | default
(.Values.workers.kerberosInitContainer).resources | default dict }}
{{- if and (semverCompare ">=2.8.0" .Values.airflowVersion)
$kerberosInitContainerEnabled }}
- name: kerberos-init
image: {{ template "airflow_image" . }}
+ securityContext: {{- toYaml
.Values.workers.kerberosInitContainer.securityContexts.container | nindent 12 }}
+ lifecycle: {{- toYaml
.Values.workers.kerberosInitContainer.containerLifecycleHooks | nindent 12 }}
Review Comment:
We will need to add additional test cases for these options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
