jscheffl commented on code in PR #60706: URL: https://github.com/apache/airflow/pull/60706#discussion_r2701346201
########## providers/google/docs/changelog.rst: ########## @@ -80,11 +58,15 @@ Misc * ``Check team boundaries in connections (#59476)`` * ``Added missing comma to bq empty dataset operator docstring (#60066)`` * ``Migrate google provider to use airflow.sdk.configuration.conf (#59986)`` +* ``Kubernetes Pod Operator: Skip async defferal when pod already complete (#58684)`` Review Comment: No, it adjusted an interface to pass context. Not tests. But no outside interface. But actually looking at the PR again we now have a coupling problem I realize: The GKE change is depending on the K8s provider version and vice-versa. The method signature was changed - So we now have a problem if you use the previous google provider and you upgrade K88s provider and the other way around if you use the newer Google provider you must upgrade K8s provider as well. We missed this during review! How can we fix this? I assume for GKE we need to set minimum provider version of cncf-kubernetes now to 10.12.1 at least? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
