HARDIK-WEB-OSS commented on code in PR #60733:
URL: https://github.com/apache/airflow/pull/60733#discussion_r2702281814
##########
providers/google/src/airflow/providers/google/cloud/hooks/bigquery.py:
##########
@@ -215,7 +216,7 @@ def get_conn(self) -> BigQueryConnection:
hook=self,
)
- def get_client(self, project_id: str = PROVIDE_PROJECT_ID, location: str |
None = None) -> Client:
Review Comment:
Hi @sjyangkevin, thank you for the sharp review!
You are absolutely right—the existing hint was already `Client`, and my
mention of `Any` in the initial description was a mistake on my part. My
apologies for the oversight.
My intention was to align this hook with others that use the explicit
`bigquery.Client` naming convention for better clarity as we move toward
Airflow 3.0 standards. I have updated the PR description to accurately reflect
this and removed the newsfragment as it is not a significant change.
If you feel this explicit naming is unnecessary given the existing import, I
am happy to close this PR and look for actual `Any` return types in other areas
of the Google provider instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
