Fury0508 commented on PR #60728: URL: https://github.com/apache/airflow/pull/60728#issuecomment-3765223435
> Looks OK for me. > > Just a bit unsure - so would request another pair of eyes - I saw it also today (before this PR) that my venv is "wiped" after running soe prek commands... alwas need to re-sync my UV venv... is it intended by pre-commit checks to change / alter venvs? Or shall a temporary secondary be created for this check then? > > Otherwise LGTM Good point! I didn't think about how this would affect local development - only focused on catching the dependency issues in CI. So yeah, wiping the venv every time someone runs pre-commit hooks is definitely annoying. Should this maybe only run in CI and not locally? Or would creating a temp venv for just this check work better? Not sure what's the best fix here - happy to adjust based on what you think makes sense! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
