Miretpl commented on code in PR #60751:
URL: https://github.com/apache/airflow/pull/60751#discussion_r2702584029
##########
chart/files/pod-template-file.kubernetes-helm-yaml:
##########
@@ -42,7 +42,7 @@ metadata:
{{- end }}
annotations:
{{- toYaml $podAnnotations | nindent 4 }}
- {{- if .Values.workers.kerberosInitContainer.enabled }}
+ {{- if or .Values.workers.kubernetes.kerberosInitContainer.enabled
.Values.workers.kerberosInitContainer.enabled }}
Review Comment:
I agree that this is the right time for a discussion about version 2.0 and,
in general, what should/shouldn't be a part of Helm Chart.
Personally, I don't like inconsistencies, but I don't have a strong opinion
on which way could be better, so I guess I will leave it as it is in PR.
I will add some comments in values and fix spacing (I have no idea how it
happened) \+ rebase, and it should be good to merge.
Regarding the joining discussion, I will be happy to give my
perspective/opinion during it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
