KamranImaaz commented on PR #60712: URL: https://github.com/apache/airflow/pull/60712#issuecomment-3767283665
> Hey @KamranImaaz , I went over the PR more thoroughly and I think that I've accidentally misled you - I had initially thought that we use `try..except` in both the operators and hooks (which is indeed not necessary), but as it seems - the hook actually calls the API straight forward, and then the operators use `try..except` to reach idempotency in action, which is already the desired behavior. When you delete a table and the instance does not exist, it rightously raises a `RuntimeError` error - because the instance is assumed to exist so you would be able to delete the table (whether it exists or not). If you run the Delete table operator, and the instance does not exist - it means that this assumption is wrong (regardless of the idempotency of the table), and the user needs to be alerted about it as a failure of the operator. I sincerely apologize for missing it - but unfortunately it seems that we won't get too much from this one. I'm aware that it's important for you to get y our 3rd PR merged soon - so please try to look for existing issues labeled as [good first issue](https://github.com/apache/airflow/issues?q=is%3Aissue%20state%3Aopen%20label%3Aprovider%3Agoogle%20label%3A%22good%20first%20issue%22), and let me know. Yes @shahar1 That doubt I was having initially. That's why I did not pushed it in initial commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
