shahar1 commented on PR #60756: URL: https://github.com/apache/airflow/pull/60756#issuecomment-3767363966
> > Hey Shruti, > > > > I'd kindly suggest to read and adhere to the [guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) regarding Gen-AI contributions. Specifically: > > > > * `Ensure that you review and understand all code generated by Gen-AI tools before including it in your PR - do not blindly trust the generated code.` > > * `State in your PR description that you have used Gen-AI tools to assist in creating the PR.` > > > > You've created an entire new document regarding the usage of Azure AD in the securty docs of Airflow's core, instead of modifying the existing one in the fab provider - and I do suspect that it's the direct result of uncontrolled AI usage (which is not mentioned as well). Using AI like that makes it difficult for maintainers to assess the reliability and credibility of the contribution. I'm happy to see your recent activity in the project and I'm aware that you make a lot of effort - but please consider it for your next contributions. If you want to fix this PR, feel free - but I'll appreciate if you could try to do it without further usage of AI, and test that it actually works. > > I'm So Sorry about this - I should have handled it better. > I missed the Gen-AI disclosure in the PR description and I also placed the Azure AD example in the core security docs instead of extending the existing FAB provider documentation. That was my mistake. > I’ve now fixed this by: > - Moving the Azure AD example into the existing Flask-AppBuilder webserver authentication docs > - Removing the standalone core security document > - Updating the PR description to explicitly disclose Gen-AI usage > - Reducing the scope to a concrete, example-level addition consistent with existing FAB OAuth examples. Apology accepted :) It looks better, but still I have no way to assess that it actually works as I don't work with Azure (yet). Are you (or anyone else, maybe issue's OP) able to test that it works as expected? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
