amoghrajesh opened a new pull request, #60771: URL: https://github.com/apache/airflow/pull/60771
<!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [x] No --- Previously the task sdk serializers like iceberg and deltalake were importing `get_fernet()` from `airflow.models.crypto`, creating a dependency on airflow-core. Through this change I am trying to decouple task sdk from airflow-core by creating duplicate of crypto in `airflow.sdk.crypto` with `get_fernet()` implementation, allowing task sdk to encrypt sensitive data without depending on core. I had a thought of removing the fernet encryption but we will need to retain it because it provides security for custom XCom backends that store data in object storage. Without encryption, catalog credentials and storage options would be stored as plaintext json files in these custom backends, accessible to anyone with bucket read permissions. The implementation duplicates ~120 lines from airflow-core but maintains security boundaries: task SDK uses its own configuration, and both components can evolve independently. * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
