ashb commented on code in PR #60781:
URL: https://github.com/apache/airflow/pull/60781#discussion_r2705469483
##########
providers/keycloak/src/airflow/providers/keycloak/auth_manager/keycloak_auth_manager.py:
##########
@@ -162,13 +164,7 @@ def refresh_tokens(self, *, user: KeycloakAuthManagerUser)
-> dict[str, str]:
client = self.get_keycloak_client()
return client.refresh_token(user.refresh_token)
except KeycloakPostError as exc:
- log.warning(
- "KeycloakPostError encountered during token refresh. "
- "Suppressing the exception and returning None.",
- exc_info=exc,
- )
-
- return {}
+ raise AuthManagerRefreshTokenExpiredException(exc)
Review Comment:
This is going to fail when the provider is used with older versions of
Airflow isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
