shahar1 commented on code in PR #60808:
URL: https://github.com/apache/airflow/pull/60808#discussion_r2707031705
##########
task-sdk/src/airflow/sdk/__init__.py:
##########
@@ -176,7 +179,13 @@ def __getattr__(name: str):
import importlib
mod = importlib.import_module(module_path, __name__)
- val = getattr(mod, name)
+
+ # try and get the attribute from the module
+ # if it doesn't exist (for modules like macros), return module itself
+ try:
+ val = getattr(mod, name)
+ except AttributeError:
+ val = mod
Review Comment:
I'm a bit concerned of this workaround, as it might backfire in potential
future namespace-naming conflicts. I'd maybe limit it only to the modules that
require this:
```suggestion
# try and get the attribute from the module
# if it doesn't exist (for modules like macros), return module itself
try:
val = getattr(mod, name)
except AttributeError:
if name == "macros":
val = mod
else:
raise
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
