gooosetavo commented on issue #60134:
URL: https://github.com/apache/airflow/issues/60134#issuecomment-3774119770
@GaneshPatil7517 I can confirm your PR fixes the issue!
Here's a test script you can run in the project root to test this:
```bash
#!/bin/bash
CHART_DIR="$(dirname "$0")/chart"
run_probe_check() {
local description="$1"
local helm_args="$2"
local probe_name="$3"
echo "=== $description ==="
# Capture both output and error
output_and_err=$(helm template airflow "$CHART_DIR" -s
templates/scheduler/scheduler-deployment.yaml $helm_args 2>&1)
probe_output=$(echo "$output_and_err" | grep -A10 "$probe_name:")
if echo "$output_and_err" | grep -q "Error:"; then
echo "$output_and_err"
elif [ -n "$probe_output" ]; then
echo "$probe_output"
else
echo "<no output>"
fi
}
run_probe_check "livenessProbe enabled" "" "livenessProbe"
run_probe_check "livenessProbe disabled" "--set
scheduler.livenessProbe.enabled=false" "livenessProbe"
run_probe_check "readinessProbe enabled" "--set
scheduler.readinessProbe.enabled=true" "readinessProbe"
run_probe_check "readinessProbe disabled" "--set
scheduler.readinessProbe.enabled=false" "readinessProbe"
run_probe_check "startupProbe enabled" "" "startupProbe"
run_probe_check "startupProbe disabled" "--set
scheduler.startupProbe.enabled=false" "startupProbe"
```
output from your branch:
```
=== livenessProbe enabled ===
livenessProbe:
initialDelaySeconds: 10
timeoutSeconds: 20
failureThreshold: 5
periodSeconds: 60
exec:
command:
- sh
- -c
- |
CONNECTION_CHECK_MAX_COUNT=0
AIRFLOW__LOGGING__LOGGING_LEVEL=ERROR exec /entrypoint \
=== livenessProbe disabled ===
<no output>
=== readinessProbe enabled ===
readinessProbe:
initialDelaySeconds: 10
timeoutSeconds: 20
failureThreshold: 5
periodSeconds: 60
exec:
command:
- sh
- -c
- |
CONNECTION_CHECK_MAX_COUNT=0
AIRFLOW__LOGGING__LOGGING_LEVEL=ERROR exec /entrypoint \
=== readinessProbe disabled ===
<no output>
=== startupProbe enabled ===
startupProbe:
initialDelaySeconds: 0
timeoutSeconds: 20
failureThreshold: 6
periodSeconds: 10
exec:
command:
- sh
- -c
- |
CONNECTION_CHECK_MAX_COUNT=0
AIRFLOW__LOGGING__LOGGING_LEVEL=ERROR exec /entrypoint \
=== startupProbe disabled ===
<no output>
```
output from main (schema doesn't permit setting some of these values):
```
=== livenessProbe enabled ===
livenessProbe:
initialDelaySeconds: 10
timeoutSeconds: 20
failureThreshold: 5
periodSeconds: 60
exec:
command:
- sh
- -c
- |
CONNECTION_CHECK_MAX_COUNT=0
AIRFLOW__LOGGING__LOGGING_LEVEL=ERROR exec /entrypoint \
=== livenessProbe disabled ===
Error: values don't meet the specifications of the schema(s) in the
following chart(s):
airflow:
- at '/scheduler/livenessProbe': additional properties 'enabled' not allowed
=== readinessProbe enabled ===
Error: values don't meet the specifications of the schema(s) in the
following chart(s):
airflow:
- at '/scheduler': additional properties 'readinessProbe' not allowed
=== readinessProbe disabled ===
Error: values don't meet the specifications of the schema(s) in the
following chart(s):
airflow:
- at '/scheduler': additional properties 'readinessProbe' not allowed
=== startupProbe enabled ===
startupProbe:
initialDelaySeconds: 0
timeoutSeconds: 20
failureThreshold: 6
periodSeconds: 10
exec:
command:
- sh
- -c
- |
CONNECTION_CHECK_MAX_COUNT=0
AIRFLOW__LOGGING__LOGGING_LEVEL=ERROR exec /entrypoint \
=== startupProbe disabled ===
Error: values don't meet the specifications of the schema(s) in the
following chart(s):
airflow:
- at '/scheduler/startupProbe': additional properties 'enabled' not allowed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
