anishgirianish commented on issue #60558: URL: https://github.com/apache/airflow/issues/60558#issuecomment-3775740858
> [@anishgirianish](https://github.com/anishgirianish) - I think that looks good, though I don't have recent knowledge of what existing FileSystem implementations looked like to confirm it matches others super closely. > > _(I commented this on the PR)_ I see lots of tests for connection parsing, and I was going to comment about having an integration test - but I suppose as long as the connection is passed as expected, sshfs is going to handle all that. > > Were you able to do a full test with an SSH/SFTP system? Thanks for the review, @fritz-astronomer! Yes, I spun up a local SFTP server with Docker and ran through the basic operations - reads, writes, listing, deletes all worked fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
