amoghrajesh commented on code in PR #60826:
URL: https://github.com/apache/airflow/pull/60826#discussion_r2711426573
##########
task-sdk/src/airflow/sdk/log.py:
##########
@@ -185,23 +198,37 @@ def init_log_file(local_relative_path: str) -> Path:
)
-def load_remote_log_handler() -> RemoteLogIO | None:
- from airflow.logging_config import get_remote_task_log
+def _load_logging_config() -> None:
+ """Load and cache the remote logging configuration from SDK config."""
+ from airflow.sdk._shared.logging.remote import discover_remote_log_handler
+ from airflow.sdk._shared.module_loading import import_string
+ from airflow.sdk.configuration import conf
- return get_remote_task_log()
+ fallback =
"airflow.config_templates.airflow_local_settings.DEFAULT_LOGGING_CONFIG"
Review Comment:
Umm no, this needs to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
