kaxil commented on PR #60804:
URL: https://github.com/apache/airflow/pull/60804#issuecomment-3782375867

   @potiuk Alternate approach is here in 
https://github.com/apache/airflow/pull/60919 which uses pure uvicorn signals to 
increment/decrement workers.
   
   **Limitations**:
     - `workers=1` needs workaround (briefly scales to 2 during refresh)
     - uvicorn's `SIGTTOU` kills newest worker (LIFO) unlike gunicorn which 
kills oldest (FIFO), so we send SIGTERM directly to old PIDs instead
   
   The LIFO thing is worth noting since it's a non-obvious difference between 
`uvicorn` and `gunicorn` that anyone else looking at this would run into.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to