Copilot commented on code in PR #60957:
URL: https://github.com/apache/airflow/pull/60957#discussion_r2718888332
##########
airflow-core/tests/unit/models/test_dag.py:
##########
@@ -1998,6 +1998,34 @@ def test_dags_needing_dagruns_assets(self, dag_maker,
session):
dag_models = query.all()
assert dag_models == [dag_model]
+ def test_dags_needing_dagruns_query_count(self, dag_maker, session):
+ """Test that dags_needing_dagruns avoids N+1 on adrq.asset access."""
+ num_assets = 10
+ assets = [Asset(uri=f"test://asset{i}", group="test-group") for i in
range(num_assets)]
+
+ with dag_maker(
+ session=session,
+ dag_id="my_dag",
+ max_active_runs=10,
+ schedule=assets,
+ start_date=pendulum.now().add(days=-2),
+ ):
+ EmptyOperator(task_id="dummy")
+
+ dag_model = dag_maker.dag_model
+ asset_models = dag_model.schedule_assets
+ assert len(asset_models) == num_assets
+ for asset_model in asset_models:
+ session.add(AssetDagRunQueue(asset_id=asset_model.id,
target_dag_id=dag_model.dag_id))
+ session.flush()
+
+ # Clear identity map so N+1 on adrq.asset is exposed
+ session.expire_all()
+
+ with assert_queries_count(6):
Review Comment:
The expected query count of 6 doesn't match the PR description which states
'After: 4 queries'. Either the assertion should be updated to 4, or the PR
description should be updated to explain why 6 queries are expected.
```suggestion
with assert_queries_count(4):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
