anishgirianish commented on PR #60920: URL: https://github.com/apache/airflow/pull/60920#issuecomment-3793115547
Hi @o-nikolas, thanks for the review!
Yes, I did some manual testing. Set up AWS Batch (Fargate) to verify the
changes work end-to-end.
Built a Docker image with the PR changes on Airflow 3.0.1 and ran it on AWS
Batch.
**Job succeeded:**
<img width="1397" height="828" alt="aws-batch-console-job-succeeded"
src="https://github.com/user-attachments/assets/54cfd80d-17e3-4045-acfd-1f227c7fa299";
/>
**Logs output:**
<img width="1461" height="828" alt="cloud-watch-logs-output"
src="https://github.com/user-attachments/assets/2e08c323-078b-4562-9d92-1e1784f54776";
/>
The logs show:
AwsBatchExecutor imported successfully
supports_multi_team: True
**Image in ECR:**
<img width="1461" height="780" alt="ecr-repository-image-upload"
src="https://github.com/user-attachments/assets/52506e72-d219-4439-95d3-ace64e0021d0";
/>
Everything works - the executor loads correctly with `supports_multi_team`
enabled, and the config changes (moving to
`self.conf` and instance-level `max_submit_job_attempts`) don't break
anything.
The `test_team_config` unit test covers the team isolation logic.
Let me know if you'd like me to test anything else!
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
