jscheffl opened a new pull request, #61001:
URL: https://github.com/apache/airflow/pull/61001

   While I was hunting for a bug in OAuth I realized that the typing of Python 
code in Fab is... missing in most part. This PR adds more typing hints to the 
providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py
 - and as a consequence I found a lot of warnings and mypy errors alongside 
which I needed to fix to make tests and mypy happy again.
   
   Not sure whether my type fixes are introducing some kind of breaking 
changes... but I assume Fab is "not a kind of public API"? Therefore would 
merge only based on an expert review like @vincbeck or @potiuk
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [ ] No (please specify the tool below)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to