SameerMesiah97 commented on PR #60532: URL: https://github.com/apache/airflow/pull/60532#issuecomment-3794509936
> For me by pure code reading the PR looks okay for me. I am not sure and can you tell me why you made changes in config loading in parallel to the changes in watching? Feeling like this might be a reason which I do not see and might be better a separate PR. The modified implementation for `watch_pod_events` will now call `_load_config` mutliple times through get_conn. It was indeed possible for my new implementation to work without modifying `_load_config`. In fact, this is what I initially implemented. But then I observed that the task logs were being polluted with logs from config loading along with the event messages from the target pod. Since this is an observability function, I added a small config-loading guard to ensure that the config is loaded once per hook instance and avoids repeated log spam when the watch reconnects. That’s why the changes ended up in the same PR. > As I am not an expert on K9s event watch, this feature was introduced by @wolfdn Can you help me with an opinion on this? Was there a reason that you did not make a watch loop for the events? I would love to hear feedback from @wolfdn on this as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
