arjav1528 commented on code in PR #60394:
URL: https://github.com/apache/airflow/pull/60394#discussion_r2724462588
##########
providers/google/src/airflow/providers/google/cloud/triggers/cloud_run.py:
##########
@@ -71,6 +74,7 @@ def __init__(
impersonation_chain: str | Sequence[str] | None = None,
polling_period_seconds: float = 10,
timeout: float | None = None,
+ transport: Literal["rest", "grpc"] | None = "grpc",
Review Comment:
You're right. The default should be None to match CloudRunHook,
CloudRunAsyncHook, and CloudRunExecuteJobOperator, which all default to None.
This allows the Google client library to auto-select the transport consistently
in both sync and deferrable modes.
I'll change line 77 to transport: Literal["rest", "grpc"] | None = None and
simplify _get_async_hook() to just pass self.transport directly without the
None-to-grpc conversion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
