SameerMesiah97 commented on code in PR #60999:
URL: https://github.com/apache/airflow/pull/60999#discussion_r2724461497
##########
task-sdk/src/airflow/sdk/definitions/_internal/templater.py:
##########
@@ -108,14 +373,6 @@ def resolve_template_files(self) -> None:
log.exception("Failed to get source %s", item)
self.prepare_template()
- def _should_render_native(self, dag: DAG | None = None) -> bool:
- # Operator explicitly set? Use that value, otherwise inherit from DAG
- render_op_template_as_native_obj = getattr(self,
"render_template_as_native_obj", None)
- if render_op_template_as_native_obj is not None:
- return render_op_template_as_native_obj
-
- return dag.render_template_as_native_obj if dag else False
-
Review Comment:
I do not understand why you removed this conditional check. Would it not
render operator level overrides for `render_template_as_native_obj` inert? If
you have a strong justification for this, I would advise explaining this change
in the PR description as this is a breaking change in terms of behavior. Unless
it was an accidental refactor, you might want to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
