Saadmadni84 commented on PR #60942: URL: https://github.com/apache/airflow/pull/60942#issuecomment-3795437240
> > > 1. CI currently fails - please fix. > > > 2. Have you tested the changes on a real GCS bucket to ensure that it works? > > > > > > Thanks for the feedback. > > I’ve updated the implementation to gracefully handle environments where object-level retention is not supported by the installed google-cloud-storage version. > > The hook now safely checks for retention support, logs a warning when it’s unavailable, and skips retention instead of raising. Tests were updated to cover this scenario. > > I ran the Google provider hook and operator tests locally under compatibility constraints, and all tests pass. CI has been re-run with these changes. > > Thanks for updating! I reran the CI workflows and unfortunately they stilli fail. Also, It's important for me that the changes will be tested against real GCS instances and not only in Airflow's unit tests, to ensure that it really behaves as expected. If you're unnable to do so for any reason, please let me know and I'll take care of it. Thanks for checking and for rerunning the CI workflows. I understand the importance of validating these changes against a real GCS instance and agree that this is the best way to ensure the behavior matches expectations beyond Airflow’s unit tests. At the moment, I’m unfortunately unable to create or access a real GCS account due to account and billing constraints on my side. Because of this, I’m not able to run integration tests against an actual GCS environment myself. If it works for you, I’d appreciate it if you could handle the testing against a real GCS instance. Alternatively, if there’s an approved way for me to test this (for example, using a project, credentials, or a different setup you recommend), please let me know and I’ll be happy to follow that approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
