dheerajturaga commented on PR #60752: URL: https://github.com/apache/airflow/pull/60752#issuecomment-3795447451
> Thanks for the PR! > > It's more correct approach compared to #60596. However, `airflow fab-db` CLI commands might be a better way to implement this. Instead of coupling the DB Manager with the Executor, we could provider the DB Manger directly via the CLI. > > https://github.com/apache/airflow/blob/7524107bf5ca6254abf43e024c33c1fb5e1dd7c6/providers/fab/src/airflow/providers/fab/cli/definition.py#L366-L371 > > For rest of the DB Manager implementation, we just need to take `providers/fab/src/airflow/providers/fab/auth_manager/cli_commands/db_command.py` as example. Hey @jason810496, thanks for reviewing. I want to implement a edge-db cli commands to manage the edge tables in a followup. However, When running `airflow db reset/migrate` commands, FAB db managers get loaded and used. This PR is an attempt to align executor behavior with the auth manager behavior. Without these hooks, cleaning up the db and migrations for executors would need to be managed separately from the core which imo is not a clean approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
