uplsh580 opened a new pull request, #61036:
URL: https://github.com/apache/airflow/pull/61036

   ## Related Issues
   Issue: https://github.com/apache/airflow/issues/61033
   
   ## Summary
   This PR ensures that Airflow CLI commands are executed with the `server` 
process context by default.
   This is achieved by setting the `_AIRFLOW_PROCESS_CONTEXT` environment 
variable to `"server"` within the core CLI decorators (`action_cli` and 
`suppress_logs_and_warning`).
   
   ## Rationale
   Previously, commands like `airflow dag-processor -B <bundle_name>` failed 
with an `AirflowNotFoundException` when initializing bundles that require 
database connections (e.g., `GitDagBundle`). 
   
   The failure occurred because:
   1. The `-B` flag triggers bundle validation (`validate_dag_bundle_arg`) 
during the command initialization phase.
   2. At this early stage, the `server` context was not yet set, causing the 
Task SDK to skip `MetastoreBackend` and fail to resolve connections from the 
metadata database.
   
   By moving the context setting to the decorator level, we ensure that all CLI 
management commands have the necessary privileges to access database-backed 
secrets before any validation or execution logic runs.
   
   ## Key Changes
   - **`airflow/utils/cli.py`**: 
       - Set `_AIRFLOW_PROCESS_CONTEXT = "server"` in `action_cli` decorator 
when `check_db` is True.
       - Set `_AIRFLOW_PROCESS_CONTEXT = "server"` in 
`suppress_logs_and_warning` decorator.
   - **`airflow/cli/commands/connection_command.py`**: Removed redundant manual 
environment settings in `connections_get` and `connections_test`.
   - **Tests**: Added unit tests in `tests/unit/utils/test_cli_util.py` to 
verify the environment variable is correctly set during CLI execution.
   
   ## Test plan
   1. Configure a DAG bundle that requires a connection (e.g., GitDagBundle).
   2. Run `airflow dag-processor -B <bundle_name>`.
   3. Verify the command starts successfully without `AirflowNotFoundException`.
   4. Run existing connection commands (e.g., `airflow connections get`) to 
ensure no regressions.
   
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull 
request.
   Write a good git commit message following this guide: 
http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the 
documentation.
   
   Feel free to ping (in general) for the review if you do not see reaction for 
a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we 
sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [x] Yes (please specify the tool below)
   - Gemini 3 flash
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to