jedcunningham commented on code in PR #61027:
URL: https://github.com/apache/airflow/pull/61027#discussion_r2726382530


##########
chart/newsfragments/61027.significant.rst:
##########
@@ -0,0 +1,4 @@
+Add ``dags.gitSync.version`` configuration
+
+The chart now uses ``dags.gitSync.version`` to determine what version of git 
sync is used. The ``images.gitSync.tag`` value does not influence this.
+The default ``dags.gitSync.version`` is ``4.4.2``. If you are using git sync 
v3, you must set ``dags.gitSync.version: 3.x.x`` explicitly.

Review Comment:
   Fair point. I agree it'd be very rare, but still breaking. I think celery is 
a very different situation just because of its popularity.
   
   But, maybe we just revert and let it ride as-is for 1.19 and remove support 
for 3 in the next release completely, along with all the other cleanup we will 
be doing. Let me sleep on it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to