chen0427ok commented on code in PR #59374:
URL: https://github.com/apache/airflow/pull/59374#discussion_r2726524285
##########
airflow-core/src/airflow/ui/tests/e2e/pages/DagsPage.ts:
##########
@@ -333,8 +608,30 @@ export class DagsPage extends BasePage {
* Wait for DAG list to be rendered
*/
private async waitForDagList(): Promise<void> {
- await
expect(this.page.locator('[data-testid="dag-id"]').first()).toBeVisible({
- timeout: 10_000,
- });
+ // Wait for either card-list or table-list to be visible
+ const cardList = this.page.locator('[data-testid="card-list"]');
+ const tableList = this.page.locator('[data-testid="table-list"]');
+
+ await expect(cardList.or(tableList)).toBeVisible({ timeout: 30_000 });
Review Comment:
"Thanks for the guidance! I realized the CI failure was caused by the test
timing out when the filter result was empty (displaying 'No Dag found' instead
of a list).
I've updated waitForDagList in DagsPage.ts to correctly handle the 'No Dag
found' state. I verified the fix locally using the command you provided (breeze
testing ui-e2e-tests --test-pattern "dags-list.spec.ts"), and all tests passed
successfully."
<img width="1218" height="842" alt="截圖 2026-01-26 下午2 55 56"
src="https://github.com/user-attachments/assets/53f916f3-4b25-465d-bd04-788db7af2122";
/>
<img width="1230" height="852" alt="截圖 2026-01-26 下午2 56 07"
src="https://github.com/user-attachments/assets/48706c25-c0c1-4fef-b4e2-e7cdf7286442";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
