chirodip98 commented on code in PR #60688:
URL: https://github.com/apache/airflow/pull/60688#discussion_r2726943814


##########
providers/google/src/airflow/providers/google/cloud/hooks/datafusion.py:
##########
@@ -508,8 +545,8 @@ def stop_pipeline(self, pipeline_name: str, instance_url: 
str, namespace: str =
         url = os.path.join(
             self._base_url(instance_url, namespace),
             quote(pipeline_name),
-            "workflows",

Review Comment:
   However @shahar1 I have a suggestion here
   The current implemetation of the stop_pipeline hook actually implements 
https://cdap.atlassian.net/wiki/spaces/DOCS/pages/477560983/Lifecycle+Microservices#Stop-a-Program
 which actually stops a program not a Run
   
   Maybe we can explore 
https://cdap.atlassian.net/wiki/spaces/DOCS/pages/477560983/Lifecycle+Microservices#Stop-a-Program-Run
 here.
   
   
   Also this was only handling the case of stoping BATCH pipelines, which has 
been refactored



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to