mik-laj commented on a change in pull request #6749: [AIRFLOW-6193] Do not use
asserts in Airflow main code
URL: https://github.com/apache/airflow/pull/6749#discussion_r355145894
##########
File path: airflow/contrib/example_dags/example_kubernetes_executor_config.py
##########
@@ -45,7 +45,8 @@ def test_volume_mount():
foo.write('Hello')
return_code = os.system("cat /foo/volume_mount_test.txt")
- assert return_code == 0
+ if not return_code:
Review comment:
I prefer the previous assertions because it expresses intentions better.
> Explicit is better than implicit.
https://www.python.org/dev/peps/pep-0020/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
