vincbeck commented on PR #61061: URL: https://github.com/apache/airflow/pull/61061#issuecomment-3801514598
> Thank you for your review. > > 1. Regarding usage and unused code: This PR aims to resolve Issue [ Replace connexion with fast-api: initialization, constants, exceptions, schemas. #60945](https://github.com/apache/airflow/issues/60945), which I understand requires setting up the infrastructure (initialization, constants, exceptions, patterns) in preparation for migration. Therefore, these files are currently not used by endpoints. > 2. Regarding directory paths: I created a new module located at .../www/api_fastapi to reflect the structure of the existing FAB API. However, if .../auth_manager/api_fastapi is the intended location for these new FastAPI components, I would be happy to move them there. Should I merge my changes into that existing directory? I see. I would say, yes please do not create a new directory but instead use the existing one. Also, ideally I would like to see the usage of whatever you are defining. The reason is, I just want to avoid defining constants, variables, classes etc that might not be used later. So ideally, can you please create things you are using, that makes it also easier to review and understand the reason. Thanks for taking this work though :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
