SameerMesiah97 commented on code in PR #61132:
URL: https://github.com/apache/airflow/pull/61132#discussion_r2733932165
##########
task-sdk/src/airflow/sdk/bases/sensor.py:
##########
@@ -250,12 +250,15 @@ def run_duration() -> float:
def resume_execution(self, next_method: str, next_kwargs: dict[str, Any] |
None, context: Context):
try:
Review Comment:
I would add a comment here explaining why there are nested try/except
blocks. Perhaps something like:
`Nested try/except ensures TaskDeferralTimeout conversion does not bypass
soft_fail / never_fail handling.`
Makes it easier to reason about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
