vincbeck commented on code in PR #61145:
URL: https://github.com/apache/airflow/pull/61145#discussion_r2737124785
##########
providers/amazon/src/airflow/providers/amazon/aws/operators/eks.py:
##########
@@ -104,17 +104,43 @@ def _create_compute(
nodeRole=nodegroup_role_arn,
**create_nodegroup_kwargs,
)
- if wait_for_completion:
- log.info("Waiting for nodegroup to provision. This will take some
time.")
- wait(
- waiter=eks_hook.conn.get_waiter("nodegroup_active"),
- waiter_delay=waiter_delay,
- waiter_max_attempts=waiter_max_attempts,
- args={"clusterName": cluster_name, "nodegroupName":
nodegroup_name},
- failure_message="Nodegroup creation failed",
- status_message="Nodegroup status is",
- status_args=["nodegroup.status"],
+ try:
+ if wait_for_completion:
+ log.info("Waiting for nodegroup to provision. This will take
some time.")
+ wait(
+ waiter=eks_hook.conn.get_waiter("nodegroup_active"),
+ waiter_delay=waiter_delay,
+ waiter_max_attempts=waiter_max_attempts,
+ args={"clusterName": cluster_name, "nodegroupName":
nodegroup_name},
+ failure_message="Nodegroup creation failed",
+ status_message="Nodegroup status is",
+ status_args=["nodegroup.status"],
+ )
+ except Exception:
Review Comment:
Yep we can start with `WaiterError` and extend later if needed but I think
it should be enough. And I agree with you, I think it should be opted in by
default.
Also, can you make similar changes to your other open PRs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
