emin-ozata opened a new pull request, #61245:
URL: https://github.com/apache/airflow/pull/61245

     ### Description
   
   Fixes an authentication failure triggered when `airflowctl auth login 
--api-url` is given a base URL with a trailing slash.
   
   
     #### Problem
     When users copy the Airflow base URL from their browser's address bar 
(which typically includes a trailing slash), the `_get_base_url()`
      method concatenates it directly with path segments, creating malformed 
URLs with double slashes (e.g., `http://localhost:8080//auth`),
     resulting in "Method Not Allowed" errors.
   
     #### Solution
     Normalize the base URL by stripping trailing slashes before constructing 
endpoint paths using `rstrip("/")` in the `_get_base_url()`
     method.
   
     #### Testing
     Added test cases to verify URLs with trailing slashes are handled 
correctly for both CLI and AUTH client kinds.
   
   
   ---
   
     ### Related Issues
   
   -   #61244 
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [ ] Yes (please specify the tool below)
   
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to